Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message when the router hander definition is not standrad #2528

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Mar 17, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (56f5d51) 78.61% compared to head (fc01286) 78.62%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2528   +/-   ##
=======================================
  Coverage   78.61%   78.62%           
=======================================
  Files         630      630           
  Lines       51388    51388           
=======================================
+ Hits        40401    40403    +2     
+ Misses       9001     8999    -2     
  Partials     1986     1986           
Flag Coverage Δ
go-1.15-386 78.64% <0.00%> (ø)
go-1.15-amd64 78.65% <0.00%> (-0.01%) ⬇️
go-1.16-386 78.65% <0.00%> (+0.02%) ⬆️
go-1.16-amd64 78.64% <0.00%> (+<0.01%) ⬆️
go-1.17-386 78.66% <0.00%> (+0.02%) ⬆️
go-1.17-amd64 78.65% <0.00%> (+<0.01%) ⬆️
go-1.18-386 78.60% <0.00%> (+0.04%) ⬆️
go-1.18-amd64 78.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_server_service_handler.go 59.70% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit dfb7f5a into master Mar 20, 2023
@gqcn gqcn deleted the enhance/ghttp-router-error branch March 20, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants