Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve AddObject to support Command/*Command parameter for package gcmd #2587

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 17, 2023

No description provided.

@houseme
Copy link
Member

houseme commented Apr 17, 2023

格式化一下代码

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Format the code

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (6fb26c4) 78.68% compared to head (72b446f) 78.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
- Coverage   78.68%   78.66%   -0.02%     
==========================================
  Files         630      630              
  Lines       51530    51533       +3     
==========================================
- Hits        40546    40541       -5     
- Misses       8998     9008      +10     
+ Partials     1986     1984       -2     
Flag Coverage Δ
go-1.15-386 78.69% <66.66%> (-0.01%) ⬇️
go-1.15-amd64 78.71% <66.66%> (+0.01%) ⬆️
go-1.16-386 78.71% <66.66%> (+0.01%) ⬆️
go-1.16-amd64 78.71% <66.66%> (+0.01%) ⬆️
go-1.17-386 78.71% <66.66%> (+0.02%) ⬆️
go-1.17-amd64 78.67% <66.66%> (-0.02%) ⬇️
go-1.18-386 78.59% <66.66%> (-0.02%) ⬇️
go-1.18-amd64 78.63% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gcmd/gcmd_command_object.go 52.43% <60.00%> (+0.11%) ⬆️
os/gcmd/gcmd_command.go 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit da8297d into master Apr 18, 2023
24 checks passed
@gqcn gqcn deleted the enhance/gcmd-add-object branch April 18, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants