Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve auto retrieving of ip addresses for service registering #2593

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 23, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Patch coverage: 23.00% and project coverage change: +0.14 🎉

Comparison is base (23d8ef3) 78.65% compared to head (4b8d828) 78.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2593      +/-   ##
==========================================
+ Coverage   78.65%   78.80%   +0.14%     
==========================================
  Files         631      631              
  Lines       51554    51618      +64     
==========================================
+ Hits        40552    40678     +126     
+ Misses       9012     8930      -82     
- Partials     1990     2010      +20     
Flag Coverage Δ
go-1.15-386 78.84% <23.00%> (+0.16%) ⬆️
go-1.15-amd64 78.86% <23.00%> (+0.20%) ⬆️
go-1.16-386 78.83% <23.00%> (+0.14%) ⬆️
go-1.16-amd64 78.83% <23.00%> (+0.14%) ⬆️
go-1.17-386 78.83% <23.00%> (+0.13%) ⬆️
go-1.17-amd64 78.83% <23.00%> (+0.15%) ⬆️
go-1.18-386 78.79% <23.00%> (+0.19%) ⬆️
go-1.18-amd64 78.76% <23.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/rpc/grpcx/grpcx_grpc_server.go 0.00% <0.00%> (ø)
net/ghttp/ghttp_server_graceful.go 59.55% <ø> (ø)
net/ghttp/ghttp_server_registry.go 49.43% <44.00%> (+42.98%) ⬆️
net/ghttp/ghttp_server.go 62.15% <80.00%> (-0.27%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 9171585 into master Apr 23, 2023
24 checks passed
@gqcn gqcn deleted the enhance/register-ip-retrieve branch April 23, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants