Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2561 #2431 #2598

Merged
merged 4 commits into from
Apr 27, 2023
Merged

fix issue #2561 #2431 #2598

merged 4 commits into from
Apr 27, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 24, 2023

No description provided.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix ci

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 79.45% and project coverage change: +0.01 🎉

Comparison is base (a9090e4) 78.85% compared to head (93f1e2d) 78.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.01%     
==========================================
  Files         631      631              
  Lines       51596    51685      +89     
==========================================
+ Hits        40687    40765      +78     
- Misses       8895     8904       +9     
- Partials     2014     2016       +2     
Flag Coverage Δ
go-1.15-386 ?
go-1.15-amd64 78.91% <79.45%> (+0.03%) ⬆️
go-1.16-386 78.88% <79.45%> (+<0.01%) ⬆️
go-1.16-amd64 78.86% <79.45%> (-0.02%) ⬇️
go-1.17-386 78.92% <79.45%> (+0.04%) ⬆️
go-1.17-amd64 78.91% <79.45%> (+0.02%) ⬆️
go-1.18-386 78.82% <79.45%> (+0.02%) ⬆️
go-1.18-amd64 78.81% <79.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/mssql/mssql.go 77.16% <ø> (-0.11%) ⬇️
database/gdb/gdb_core_underlying.go 73.48% <ø> (ø)
database/gdb/gdb_core.go 72.51% <79.45%> (+0.82%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 2198f0c into master Apr 27, 2023
24 checks passed
@gqcn gqcn deleted the fix/2561 branch April 27, 2023 03:35
dukepan2005 pushed a commit to dukepan2005/gf that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants