Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file registry that not works on windows #2605

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

starccck
Copy link
Contributor

solve issue #2538

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 🎉

Comparison is base (894f202) 78.80% compared to head (42a17d1) 78.92%.

❗ Current head 42a17d1 differs from pull request most recent head d222f87. Consider uploading reports for the commit d222f87 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
+ Coverage   78.80%   78.92%   +0.12%     
==========================================
  Files         631      629       -2     
  Lines       51618    51490     -128     
==========================================
- Hits        40675    40638      -37     
+ Misses       8933     8848      -85     
+ Partials     2010     2004       -6     
Flag Coverage Δ
go-1.15-386 ?
go-1.15-amd64 78.89% <100.00%> (+0.06%) ⬆️
go-1.16-386 78.88% <100.00%> (+0.06%) ⬆️
go-1.16-amd64 78.88% <100.00%> (+0.07%) ⬆️
go-1.17-386 78.86% <100.00%> (+0.05%) ⬆️
go-1.17-amd64 78.88% <100.00%> (+0.07%) ⬆️
go-1.18-386 ?
go-1.18-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/registry/file/file.go 100.00% <ø> (ø)
net/gsvc/gsvc.go 66.66% <ø> (ø)
contrib/registry/file/file_discovery.go 69.56% <100.00%> (+0.67%) ⬆️
contrib/registry/file/file_registrar.go 70.00% <100.00%> (+1.03%) ⬆️
net/gsvc/gsvc_endpoint.go 66.66% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

contrib/registry/file/file_discovery.go Outdated Show resolved Hide resolved
contrib/registry/file/file_registrar.go Outdated Show resolved Hide resolved
net/gsvc/gsvc.go Show resolved Hide resolved
@gqcn gqcn changed the title Fix gsvc on windows fix file registry that not works on windows Apr 27, 2023
@gqcn gqcn merged commit c6b9b4d into gogf:master Apr 27, 2023
12 checks passed
dukepan2005 pushed a commit to dukepan2005/gf that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants