Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve polaris relation and add copyright for polaris example #2607

Merged
merged 21 commits into from
May 5, 2023

Conversation

houseme
Copy link
Member

@houseme houseme commented Apr 27, 2023

No description provided.

@houseme houseme requested a review from gqcn April 27, 2023 08:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d9a7ee3) 78.85% compared to head (6d85b82) 78.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
- Coverage   78.85%   78.84%   -0.01%     
==========================================
  Files         631      631              
  Lines       51705    51705              
==========================================
- Hits        40770    40767       -3     
- Misses       8917     8921       +4     
+ Partials     2018     2017       -1     
Flag Coverage Δ
go-1.15-386 78.87% <100.00%> (-0.01%) ⬇️
go-1.15-amd64 78.87% <100.00%> (+<0.01%) ⬆️
go-1.16-386 78.87% <100.00%> (+<0.01%) ⬆️
go-1.16-amd64 78.86% <100.00%> (-0.02%) ⬇️
go-1.17-386 78.88% <100.00%> (+0.01%) ⬆️
go-1.17-amd64 78.87% <100.00%> (+0.01%) ⬆️
go-1.18-386 78.79% <100.00%> (-0.01%) ⬇️
go-1.18-amd64 78.81% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/registry/polaris/polaris.go 60.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit aa9d66c into master May 5, 2023
24 checks passed
@gqcn gqcn deleted the fix/upgrade-polaris-version branch May 5, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants