Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use first column name for Model.Array #2609

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 27, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 30.43% and project coverage change: -0.02 ⚠️

Comparison is base (2198f0c) 78.85% compared to head (d3ff912) 78.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2609      +/-   ##
==========================================
- Coverage   78.85%   78.84%   -0.02%     
==========================================
  Files         631      631              
  Lines       51677    51689      +12     
==========================================
  Hits        40752    40752              
- Misses       8909     8919      +10     
- Partials     2016     2018       +2     
Flag Coverage Δ
go-1.15-386 78.86% <30.43%> (+0.01%) ⬆️
go-1.15-amd64 78.88% <30.43%> (+<0.01%) ⬆️
go-1.16-386 78.86% <30.43%> (-0.01%) ⬇️
go-1.16-amd64 78.88% <30.43%> (+<0.01%) ⬆️
go-1.17-386 78.87% <30.43%> (-0.03%) ⬇️
go-1.17-amd64 78.86% <30.43%> (-0.03%) ⬇️
go-1.18-386 78.80% <30.43%> (+<0.01%) ⬆️
go-1.18-amd64 78.78% <30.43%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_select.go 72.01% <30.43%> (-1.48%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit d9a7ee3 into master Apr 28, 2023
24 checks passed
@gqcn gqcn deleted the enhance/first-column-in-array branch April 28, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants