Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing .exe suffix for cli file for windows downloading, unable replacing self cli binary #2622

Merged
merged 2 commits into from
May 8, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented May 6, 2023

修复Windows下载无exe后缀问题,同时修复下载后无法替换自身的问题。
#2618

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1408385) 78.83% compared to head (021f8ae) 78.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2622      +/-   ##
==========================================
- Coverage   78.83%   78.83%   -0.01%     
==========================================
  Files         631      631              
  Lines       51715    51715              
==========================================
- Hits        40770    40768       -2     
- Misses       8924     8926       +2     
  Partials     2021     2021              
Flag Coverage Δ
go-1.15-386 78.87% <ø> (+0.11%) ⬆️
go-1.15-amd64 78.86% <ø> (+0.01%) ⬆️
go-1.16-386 78.86% <ø> (ø)
go-1.16-amd64 78.88% <ø> (+0.02%) ⬆️
go-1.17-386 78.86% <ø> (+0.01%) ⬆️
go-1.17-amd64 78.87% <ø> (+0.03%) ⬆️
go-1.18-386 78.81% <ø> (+0.02%) ⬆️
go-1.18-amd64 78.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@houseme houseme requested a review from gqcn May 6, 2023 04:09
@gqcn gqcn changed the title Fix/gfup:修复Windows下载无exe后缀问题,同时修复下载后无法替换自身的问题。 fix missing .exe suffix for cli file for windows downloading, unable replacing self cli binary May 8, 2023
@gqcn
Copy link
Member

gqcn commented May 8, 2023

@hailaz Awesome!

@gqcn gqcn merged commit b8aeb4f into master May 8, 2023
24 checks passed
@gqcn gqcn deleted the fix/gfup branch May 8, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants