Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom endpoints configuration for package grpcx #2625

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

xxxwang1983
Copy link
Contributor

No description provided.

@gqcn
Copy link
Member

gqcn commented May 8, 2023

@xxxwang1983 请描述下您这么修改解决的是什么场景问题呢?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@xxxwang1983 Please describe what scenario problem you solved by making such a modification?

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.22 🎉

Comparison is base (ba2a7e4) 78.87% compared to head (2d08d7d) 79.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2625      +/-   ##
==========================================
+ Coverage   78.87%   79.09%   +0.22%     
==========================================
  Files         633      633              
  Lines       51974    51978       +4     
==========================================
+ Hits        40993    41112     +119     
+ Misses       8955     8829     -126     
- Partials     2026     2037      +11     
Flag Coverage Δ
go-1.15-386 79.13% <57.14%> (+0.23%) ⬆️
go-1.15-amd64 79.12% <57.14%> (+0.24%) ⬆️
go-1.16-386 79.11% <57.14%> (+0.23%) ⬆️
go-1.16-amd64 79.09% <57.14%> (+0.21%) ⬆️
go-1.17-386 79.12% <57.14%> (+0.22%) ⬆️
go-1.17-amd64 79.08% <57.14%> (+0.19%) ⬆️
go-1.18-386 ?
go-1.18-amd64 78.72% <57.14%> (+0.21%) ⬆️
go-1.19-386 ?
go-1.19-amd64 ?
go-1.20-386 ?
go-1.20-amd64 79.10% <57.14%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/rpc/grpcx/grpcx_grpc_server_config.go 61.53% <ø> (+61.53%) ⬆️
contrib/rpc/grpcx/grpcx_grpc_server.go 38.09% <57.14%> (+38.09%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xxxwang1983
Copy link
Contributor Author

我现在的使用场景是服务启动的IP和端口与外部服务通信的IP和端口不一致,需要用真是的服务地址覆盖启动地址注册到注册中心,增加的变量为了实现这个机制

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


My current usage scenario is that the IP and port of service startup are inconsistent with the IP and port of external service communication. It is necessary to overwrite the startup address with the real service address and register to the registration center. The added variables are to realize this mechanism.

@gqcn
Copy link
Member

gqcn commented May 11, 2023

@xxxwang1983 好的,我想一想。 Let me have a think.

@gqcn
Copy link
Member

gqcn commented May 23, 2023

@xxxwang1983 Any updates?

@gqcn
Copy link
Member

gqcn commented May 29, 2023

@xxxwang1983 Any updates?

@gqcn
Copy link
Member

gqcn commented May 30, 2023

@xxxwang1983

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@xxxwang1983

@gqcn gqcn changed the title 增加注册发现时的服务访问自定义功能 add custom endpoints for package grpcx Jun 2, 2023
@gqcn gqcn changed the title add custom endpoints for package grpcx add custom endpoints configuration for package grpcx Jun 2, 2023
@gqcn
Copy link
Member

gqcn commented Jun 6, 2023

@xxxwang1983

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@xxxwang1983

@gqcn
Copy link
Member

gqcn commented Jun 29, 2023

@xxxwang1983 Please AT me if this is ready.

@gogf gogf deleted a comment from Issues-translate-bot Jul 4, 2023
@gqcn gqcn merged commit 30cf3db into gogf:master Jul 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants