Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in array border exceeded in RoundRobin of package gsel #2642

Merged
merged 2 commits into from
May 23, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented May 12, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (0afedee) 78.84% compared to head (a5d5e73) 78.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   78.84%   78.82%   -0.02%     
==========================================
  Files         631      631              
  Lines       51715    51716       +1     
==========================================
- Hits        40773    40766       -7     
- Misses       8922     8929       +7     
- Partials     2020     2021       +1     
Flag Coverage Δ
go-1.15-386 78.86% <100.00%> (+0.01%) ⬆️
go-1.15-amd64 78.84% <100.00%> (-0.03%) ⬇️
go-1.16-386 78.84% <100.00%> (-0.03%) ⬇️
go-1.16-amd64 78.89% <100.00%> (+0.05%) ⬆️
go-1.17-386 78.86% <100.00%> (+0.01%) ⬆️
go-1.17-amd64 78.83% <100.00%> (-0.02%) ⬇️
go-1.18-386 78.80% <100.00%> (+0.01%) ⬆️
go-1.18-amd64 78.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/gsel/gsel_selector_round_robin.go 100.00% <100.00%> (ø)
net/gsvc/gsvc_service.go 82.05% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 0f4f2a6 into master May 23, 2023
24 checks passed
@gqcn gqcn deleted the fix/gsel-array-border branch May 23, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants