Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple methods support for united routes registering #2664

Merged
merged 7 commits into from
May 25, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented May 25, 2023

No description provided.

@gqcn gqcn changed the title add multiple methods support for object route add multiple methods support for united routes registering May 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (368312c) 78.85% compared to head (1a41aa8) 78.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
+ Coverage   78.85%   78.95%   +0.09%     
==========================================
  Files         631      629       -2     
  Lines       51789    51666     -123     
==========================================
- Hits        40840    40791      -49     
+ Misses       8926     8861      -65     
+ Partials     2023     2014       -9     
Flag Coverage Δ
go-1.15-386 78.91% <100.00%> (+0.05%) ⬆️
go-1.15-amd64 78.89% <100.00%> (-0.01%) ⬇️
go-1.16-386 78.90% <100.00%> (+0.05%) ⬆️
go-1.16-amd64 78.89% <100.00%> (+0.01%) ⬆️
go-1.17-386 78.93% <100.00%> (+0.06%) ⬆️
go-1.17-amd64 78.90% <100.00%> (+0.01%) ⬆️
go-1.18-386 ?
go-1.18-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/utils/utils_io.go 100.00% <100.00%> (+39.28%) ⬆️
net/ghttp/ghttp_request_param.go 78.22% <100.00%> (-0.22%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 2329622 into master May 25, 2023
24 checks passed
@gqcn gqcn deleted the feature/multi-methods-support-for-bind-route branch May 25, 2023 02:58
gqcn added a commit that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants