Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user name configuration support for package gredis #2684

Merged
merged 24 commits into from
Jul 6, 2023
Merged

Conversation

wanov
Copy link
Contributor

@wanov wanov commented Jun 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (ba2a7e4) 78.87% compared to head (df09f99) 78.86%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
- Coverage   78.87%   78.86%   -0.01%     
==========================================
  Files         633      633              
  Lines       51974    51975       +1     
==========================================
- Hits        40993    40991       -2     
- Misses       8955     8957       +2     
- Partials     2026     2027       +1     
Flag Coverage Δ
go-1.15-386 78.89% <100.00%> (-0.02%) ⬇️
go-1.15-amd64 78.90% <100.00%> (+0.02%) ⬆️
go-1.16-386 78.88% <100.00%> (+<0.01%) ⬆️
go-1.16-amd64 78.89% <100.00%> (+0.01%) ⬆️
go-1.17-386 78.89% <100.00%> (-0.01%) ⬇️
go-1.17-amd64 78.86% <100.00%> (-0.03%) ⬇️
go-1.18-386 78.46% <100.00%> (-0.03%) ⬇️
go-1.18-amd64 78.48% <100.00%> (-0.03%) ⬇️
go-1.19-386 78.89% <100.00%> (-0.01%) ⬇️
go-1.19-amd64 78.88% <100.00%> (-0.01%) ⬇️
go-1.20-386 78.87% <100.00%> (+0.03%) ⬆️
go-1.20-amd64 78.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gredis/gredis_config.go 77.41% <ø> (ø)
contrib/nosql/redis/redis.go 89.02% <100.00%> (+0.13%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn
Copy link
Member

gqcn commented Jun 6, 2023

@wanov 你好,感谢参与贡献,请提交对应修改的单元测试。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Hello @wanov, thanks for participating in the contribution, please submit the unit test corresponding to the modification.

Copy link
Contributor Author

@wanov wanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test

@gqcn
Copy link
Member

gqcn commented Jun 27, 2023

@wanov 你好,你的单例执行失败了,应该是和当前项目的CI中的redis server不对应,请参考已有代码改进一下呢。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@wanov Hello, your singleton execution failed, it should not correspond to the redis server in the CI of the current project, please refer to the existing code to improve it.

Copy link
Contributor Author

@wanov wanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

人生首次PR,太刺激了~

@wanov wanov requested a review from gqcn July 4, 2023 08:37
@wanov
Copy link
Contributor Author

wanov commented Jul 4, 2023

已删除

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


deleted

@wanov wanov requested a review from gqcn July 4, 2023 13:18
@gqcn gqcn merged commit 39810a5 into gogf:master Jul 6, 2023
18 checks passed
@gqcn gqcn changed the title add redis-config Auth Username add Username configuration for redis Jul 6, 2023
@gqcn gqcn changed the title add Username configuration for redis add user name configuration for redis Jul 6, 2023
@gqcn gqcn changed the title add user name configuration for redis add user name configuration support for gredis Jul 6, 2023
@gqcn gqcn changed the title add user name configuration support for gredis add user name configuration support for package gredis Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants