-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add user name configuration support for package gredis #2684
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 78.87% 78.86% -0.01%
==========================================
Files 633 633
Lines 51974 51975 +1
==========================================
- Hits 40993 40991 -2
- Misses 8955 8957 +2
- Partials 2026 2027 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@wanov 你好,感谢参与贡献,请提交对应修改的单元测试。 |
Hello @wanov, thanks for participating in the contribution, please submit the unit test corresponding to the modification. |
# Conflicts: # contrib/nosql/redis/redis.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test
@wanov 你好,你的单例执行失败了,应该是和当前项目的CI中的redis server不对应,请参考已有代码改进一下呢。 |
@wanov Hello, your singleton execution failed, it should not correspond to the redis server in the CI of the current project, please refer to the existing code to improve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
人生首次PR,太刺激了~
已删除 |
deleted |
No description provided.