Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gdb_fun.go code comments #2687

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix gdb_fun.go code comments #2687

merged 1 commit into from
Jun 12, 2023

Conversation

oldme-git
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (bda5d25) 78.83% compared to head (3b38de7) 78.90%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   78.83%   78.90%   +0.07%     
==========================================
  Files         631      631              
  Lines       51715    51817     +102     
==========================================
+ Hits        40768    40886     +118     
+ Misses       8926     8909      -17     
- Partials     2021     2022       +1     
Flag Coverage Δ
go-1.15-386 78.92% <ø> (+0.06%) ⬆️
go-1.15-amd64 78.92% <ø> (+0.05%) ⬆️
go-1.16-386 78.91% <ø> (+0.05%) ⬆️
go-1.16-amd64 78.89% <ø> (+0.03%) ⬆️
go-1.17-386 78.91% <ø> (+0.07%) ⬆️
go-1.17-amd64 78.94% <ø> (+0.07%) ⬆️
go-1.18-386 78.84% <ø> (+0.08%) ⬆️
go-1.18-amd64 78.86% <ø> (+0.06%) ⬆️
go-1.19-386 78.92% <ø> (?)
go-1.19-amd64 78.93% <ø> (?)
go-1.20-386 78.86% <ø> (?)
go-1.20-amd64 78.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_func.go 86.10% <ø> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Jun 6, 2023
@gqcn gqcn merged commit 842e5a6 into gogf:master Jun 12, 2023
18 checks passed
@oldme-git oldme-git deleted the fix/code-comments branch August 3, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants