Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcompress_zip.go #2694

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Update gcompress_zip.go #2694

merged 2 commits into from
Jun 12, 2023

Conversation

rexxar5188
Copy link
Contributor

Fix index out of range error while the zipfile has dir __MAXOSX

Fix index out of range when zipfile has dir __MAXOSX
@rexxar5188 rexxar5188 marked this pull request as draft June 9, 2023 03:02
@rexxar5188 rexxar5188 marked this pull request as ready for review June 9, 2023 03:03
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ece368) 78.88% compared to head (aaa28c1) 78.89%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2694   +/-   ##
=======================================
  Coverage   78.88%   78.89%           
=======================================
  Files         632      632           
  Lines       51872    51872           
=======================================
+ Hits        40918    40922    +4     
+ Misses       8928     8925    -3     
+ Partials     2026     2025    -1     
Flag Coverage Δ
go-1.15-386 78.89% <0.00%> (-0.02%) ⬇️
go-1.15-amd64 78.91% <0.00%> (+0.03%) ⬆️
go-1.16-386 78.88% <0.00%> (?)
go-1.16-amd64 78.90% <0.00%> (?)
go-1.17-386 78.88% <0.00%> (-0.03%) ⬇️
go-1.17-amd64 78.92% <0.00%> (ø)
go-1.18-386 78.83% <0.00%> (-0.02%) ⬇️
go-1.18-amd64 78.84% <0.00%> (+0.03%) ⬆️
go-1.19-386 78.88% <0.00%> (-0.02%) ⬇️
go-1.19-amd64 78.89% <0.00%> (-0.03%) ⬇️
go-1.20-386 78.91% <0.00%> (?)
go-1.20-amd64 78.88% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
encoding/gcompress/gcompress_zip.go 53.19% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 46f3196 into gogf:master Jun 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants