Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service comments for command gf gen service #2714

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

horizon220222
Copy link
Contributor

To improve the readability of service, generate the comments for logic

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (15eaac3) 78.88% compared to head (4550d5e) 78.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
+ Coverage   78.88%   78.94%   +0.06%     
==========================================
  Files         631      630       -1     
  Lines       51661    51760      +99     
==========================================
+ Hits        40753    40863     +110     
+ Misses       8894     8879      -15     
- Partials     2014     2018       +4     
Flag Coverage Δ
go-1.15-386 78.91% <100.00%> (?)
go-1.15-amd64 78.89% <100.00%> (?)
go-1.16-386 ?
go-1.16-amd64 78.90% <100.00%> (+<0.01%) ⬆️
go-1.17-amd64 78.90% <100.00%> (?)
go-1.18-386 ?
go-1.18-amd64 ?
go-1.19-386 ?
go-1.19-amd64 ?
go-1.20-386 78.87% <100.00%> (?)
go-1.20-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gredis/gredis.go 38.09% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@horizon220222
Copy link
Contributor Author

16

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


16

@gqcn gqcn merged commit 8aff085 into gogf:master Jun 28, 2023
18 checks passed
@gqcn gqcn changed the title feat:add service comments. add service comments for command gf gen service Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants