Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in converting value to nil when calling IsNil return ture for gdb.Core #2720

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

niluan304
Copy link
Contributor

// iString is the type assert api for String.
type iString interface {
	String() string
}

// iNil if the type assert api for IsNil.
type iNil interface {
	IsNil() bool
}

check whether value implements the iNil interface, before iString interface.

fix issue in converting gjson.New('') and gjson.New(nil) to nil, related Issues: #2719

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c5c2938) 78.88% compared to head (27e1092) 78.90%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
+ Coverage   78.88%   78.90%   +0.01%     
==========================================
  Files         632      632              
  Lines       51880    51885       +5     
==========================================
+ Hits        40926    40939      +13     
+ Misses       8927     8924       -3     
+ Partials     2027     2022       -5     
Flag Coverage Δ
go-1.15-386 78.92% <100.00%> (+<0.01%) ⬆️
go-1.15-amd64 78.92% <100.00%> (+0.02%) ⬆️
go-1.16-386 78.93% <100.00%> (+0.04%) ⬆️
go-1.16-amd64 78.91% <100.00%> (+0.02%) ⬆️
go-1.17-386 78.93% <100.00%> (+0.01%) ⬆️
go-1.17-amd64 78.91% <100.00%> (-0.01%) ⬇️
go-1.18-386 78.84% <100.00%> (-0.02%) ⬇️
go-1.18-amd64 78.83% <100.00%> (+<0.01%) ⬆️
go-1.19-386 78.91% <100.00%> (-0.01%) ⬇️
go-1.19-amd64 78.92% <100.00%> (+<0.01%) ⬆️
go-1.20-386 78.81% <100.00%> (-0.04%) ⬇️
go-1.20-amd64 78.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_func.go 86.84% <ø> (+0.50%) ⬆️
database/gdb/gdb_core_structure.go 63.51% <100.00%> (+2.11%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn added the wip label Jun 28, 2023
@gqcn
Copy link
Member

gqcn commented Jun 28, 2023

@niluan304 It's awesome! Thanks for your contribution!

@gqcn gqcn merged commit 70d0d20 into gogf:master Jun 28, 2023
18 checks passed
@gqcn gqcn removed the wip label Jun 28, 2023
@niluan304 niluan304 deleted the fix/inil branch June 29, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants