Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chaining function Discovery to disable/enable discovery feature for package gclient; fix issue #2737 #2738

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 4, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (740dfa5) 78.85% compared to head (300bfd5) 78.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
+ Coverage   78.85%   78.93%   +0.07%     
==========================================
  Files         633      631       -2     
  Lines       51970    51854     -116     
==========================================
- Hits        40980    40930      -50     
+ Misses       8961     8907      -54     
+ Partials     2029     2017      -12     
Flag Coverage Δ
go-1.15-386 78.89% <100.00%> (+0.01%) ⬆️
go-1.15-amd64 78.89% <100.00%> (+0.01%) ⬆️
go-1.16-386 78.88% <100.00%> (+0.01%) ⬆️
go-1.16-amd64 78.86% <100.00%> (-0.02%) ⬇️
go-1.17-386 78.88% <100.00%> (+0.01%) ⬆️
go-1.17-amd64 78.87% <100.00%> (-0.01%) ⬇️
go-1.18-386 ?
go-1.18-amd64 ?
go-1.19-386 ?
go-1.19-amd64 ?
go-1.20-386 ?
go-1.20-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/gclient/gclient_chain.go 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit ba2a7e4 into master Jul 4, 2023
36 checks passed
@gqcn gqcn deleted the enhance/gclient-discovery-nil branch July 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants