Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve polaris register and discovery #2739

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

houseme
Copy link
Member

@houseme houseme commented Jul 4, 2023

@houseme houseme requested a review from gqcn July 4, 2023 10:21
@houseme houseme changed the title feat: improve polairs register and discovery feat: improve polaris register and discovery Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.25 🎉

Comparison is base (740dfa5) 78.85% compared to head (8f4f0f5) 79.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
+ Coverage   78.85%   79.11%   +0.25%     
==========================================
  Files         633      633              
  Lines       51970    52020      +50     
==========================================
+ Hits        40980    41154     +174     
+ Misses       8961     8832     -129     
- Partials     2029     2034       +5     
Flag Coverage Δ
go-1.15-386 79.15% <77.77%> (+0.27%) ⬆️
go-1.15-amd64 79.14% <77.77%> (+0.26%) ⬆️
go-1.16-386 79.15% <77.77%> (+0.27%) ⬆️
go-1.16-amd64 79.15% <77.77%> (+0.27%) ⬆️
go-1.17-386 79.13% <77.77%> (+0.26%) ⬆️
go-1.17-amd64 79.13% <77.77%> (+0.25%) ⬆️
go-1.18-386 78.74% <77.77%> (+0.28%) ⬆️
go-1.18-amd64 78.73% <77.77%> (+0.26%) ⬆️
go-1.19-386 79.13% <77.77%> (+0.29%) ⬆️
go-1.19-amd64 79.13% <77.77%> (+0.26%) ⬆️
go-1.20-386 79.13% <77.77%> (+0.25%) ⬆️
go-1.20-amd64 79.13% <77.77%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/registry/polaris/polaris_watcher.go 62.29% <0.00%> (+5.15%) ⬆️
net/gsvc/gsvc.go 66.66% <ø> (ø)
contrib/registry/polaris/polaris.go 60.00% <100.00%> (ø)
contrib/registry/polaris/polaris_discovery.go 78.72% <100.00%> (+8.95%) ⬆️
net/gsvc/gsvc_endpoints.go 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn
Copy link
Member

gqcn commented Jul 4, 2023

@houseme 针对修改的内容,没有完善polaris的单测?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme For the modified content, there is no single test for polaris?

@houseme
Copy link
Member Author

houseme commented Jul 5, 2023

@gqcn 添加了一个测试,以及新增了example

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn added a test and added an example

@gqcn gqcn merged commit 0dc4760 into master Jul 6, 2023
36 checks passed
@gqcn gqcn deleted the fix/polaris-discovery branch July 6, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants