Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix g.Wait not support OS Signal #2752 #2768

Merged
merged 2 commits into from Jul 19, 2023
Merged

fix g.Wait not support OS Signal #2752 #2768

merged 2 commits into from Jul 19, 2023

Conversation

xyqweb
Copy link
Contributor

@xyqweb xyqweb commented Jul 14, 2023

@xyqweb xyqweb closed this Jul 14, 2023
@xyqweb xyqweb reopened this Jul 14, 2023
@xyqweb xyqweb changed the title fix g.Wait not support OS Signal fix g.Wait not support OS Signal #2752 Jul 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (498b72f) 79.12% compared to head (8cec476) 79.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2768      +/-   ##
==========================================
+ Coverage   79.12%   79.14%   +0.02%     
==========================================
  Files         632      632              
  Lines       52006    52009       +3     
==========================================
+ Hits        41150    41163      +13     
+ Misses       8824     8811      -13     
- Partials     2032     2035       +3     
Flag Coverage Δ
go-1.15-386 79.18% <100.00%> (+0.04%) ⬆️
go-1.15-amd64 79.16% <100.00%> (+<0.01%) ⬆️
go-1.16-386 79.17% <100.00%> (?)
go-1.16-amd64 79.18% <100.00%> (+0.04%) ⬆️
go-1.17-386 ?
go-1.17-amd64 79.15% <100.00%> (+0.01%) ⬆️
go-1.18-amd64 78.74% <100.00%> (-0.01%) ⬇️
go-1.19-386 79.16% <100.00%> (+0.02%) ⬆️
go-1.19-amd64 79.15% <100.00%> (-0.01%) ⬇️
go-1.20-386 79.15% <100.00%> (+0.05%) ⬆️
go-1.20-amd64 79.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_server.go 64.70% <100.00%> (+2.12%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xyqweb
Copy link
Contributor Author

xyqweb commented Jul 14, 2023

@houseme @gqcn all check is passed

@xyqweb xyqweb closed this Jul 14, 2023
@xyqweb xyqweb reopened this Jul 14, 2023
@xyqweb xyqweb closed this Jul 14, 2023
@xyqweb xyqweb reopened this Jul 14, 2023
@houseme houseme requested a review from gqcn July 14, 2023 15:16
@xyqweb
Copy link
Contributor Author

xyqweb commented Jul 18, 2023

Isn't this bug fixed? @gqcn @houseme

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


g.Wait() Doesn't fix the bug that doesn't support system signals? @gqcn

@gqcn
Copy link
Member

gqcn commented Jul 19, 2023

@xyqweb I'll check this later.

@gqcn gqcn merged commit d72997d into gogf:master Jul 19, 2023
34 of 54 checks passed
@xyqweb xyqweb deleted the fix/2752 branch July 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants