Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve watch for polaris registrar #2788

Merged
merged 7 commits into from Jul 25, 2023

Conversation

houseme
Copy link
Member

@houseme houseme commented Jul 20, 2023

No description provided.

@houseme houseme requested a review from gqcn July 20, 2023 12:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 95.12% and project coverage change: +0.05 🎉

Comparison is base (4ad508c) 79.15% compared to head (3504d21) 79.20%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
+ Coverage   79.15%   79.20%   +0.05%     
==========================================
  Files         632      632              
  Lines       52174    52231      +57     
==========================================
+ Hits        41298    41371      +73     
+ Misses       8830     8816      -14     
+ Partials     2046     2044       -2     
Flag Coverage Δ
go-1.15-386 79.15% <69.51%> (-0.03%) ⬇️
go-1.15-amd64 79.17% <69.51%> (-0.02%) ⬇️
go-1.16-386 79.22% <91.46%> (+0.05%) ⬆️
go-1.16-amd64 79.16% <69.51%> (-0.03%) ⬇️
go-1.17-386 79.16% <69.51%> (-0.01%) ⬇️
go-1.17-amd64 79.15% <69.51%> (-0.01%) ⬇️
go-1.18-386 78.84% <91.46%> (+0.05%) ⬆️
go-1.18-amd64 78.82% <95.12%> (?)
go-1.19-386 79.20% <95.12%> (?)
go-1.19-amd64 79.18% <69.51%> (+0.01%) ⬆️
go-1.20-386 79.21% <91.46%> (?)
go-1.20-amd64 79.18% <95.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/registry/polaris/polaris_registry.go 85.00% <ø> (ø)
net/gsvc/gsvc_discovery.go 50.70% <0.00%> (-0.69%) ⬇️
contrib/registry/polaris/polaris_watcher.go 91.89% <95.23%> (+29.59%) ⬆️
contrib/registry/polaris/polaris_discovery.go 80.39% <100.00%> (+1.66%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 2c22f4e into gogf:master Jul 25, 2023
18 checks passed
@houseme houseme deleted the fix/polaris-discovery-0719 branch July 25, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants