Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose iClient as IClient in generated sdk for command gen ctrl #2804

Merged
merged 4 commits into from Jul 26, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 26, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (b95cb31) 79.22% compared to head (136146d) 79.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
+ Coverage   79.22%   79.28%   +0.06%     
==========================================
  Files         633      631       -2     
  Lines       52242    52122     -120     
==========================================
- Hits        41388    41327      -61     
+ Misses       8809     8759      -50     
+ Partials     2045     2036       -9     
Flag Coverage Δ
go-1.15-386 79.17% <ø> (-0.06%) ⬇️
go-1.15-amd64 79.24% <ø> (+0.04%) ⬆️
go-1.16-386 79.27% <ø> (+0.07%) ⬆️
go-1.16-amd64 79.20% <ø> (-0.01%) ⬇️
go-1.17-386 79.21% <ø> (+<0.01%) ⬆️
go-1.17-amd64 79.23% <ø> (+0.02%) ⬆️
go-1.18-386 ?
go-1.18-amd64 ?
go-1.19-386 ?
go-1.19-amd64 ?
go-1.20-386 79.22% <ø> (+0.18%) ⬆️
go-1.20-amd64 79.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit e0e0043 into master Jul 26, 2023
36 checks passed
@gqcn gqcn deleted the enhance/gen-ctrl-iclient branch July 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants