Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: psgql tx unsupport LastInsertId #2815

Merged
merged 3 commits into from Aug 3, 2023
Merged

fix: psgql tx unsupport LastInsertId #2815

merged 3 commits into from Aug 3, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Jul 31, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: +0.09% 🎉

Comparison is base (e0e0043) 79.22% compared to head (c1135fb) 79.32%.
Report is 7 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2815      +/-   ##
==========================================
+ Coverage   79.22%   79.32%   +0.09%     
==========================================
  Files         633      633              
  Lines       52242    52453     +211     
==========================================
+ Hits        41391    41606     +215     
+ Misses       8808     8786      -22     
- Partials     2043     2061      +18     
Flag Coverage Δ
go-1.15-386 ?
go-1.15-amd64 79.19% <43.75%> (+<0.01%) ⬆️
go-1.16-386 79.22% <43.75%> (+<0.01%) ⬆️
go-1.16-amd64 79.17% <43.75%> (-0.06%) ⬇️
go-1.17-386 ?
go-1.17-amd64 79.17% <43.75%> (-0.07%) ⬇️
go-1.18-386 79.29% <43.75%> (+0.44%) ⬆️
go-1.18-amd64 79.26% <43.75%> (+0.43%) ⬆️
go-1.19-386 79.27% <43.75%> (+0.05%) ⬆️
go-1.19-amd64 79.27% <43.75%> (+0.05%) ⬆️
go-1.20-386 79.33% <43.75%> (+0.14%) ⬆️
go-1.20-amd64 79.30% <43.75%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
database/gdb/gdb.go 68.34% <ø> (ø)
database/gdb/gdb_core_transaction.go 63.13% <0.00%> (-2.40%) ⬇️
database/gdb/gdb_func.go 86.71% <ø> (-0.14%) ⬇️
contrib/drivers/pgsql/pgsql.go 62.89% <42.85%> (-0.34%) ⬇️
database/gdb/gdb_core.go 72.83% <100.00%> (+0.31%) ⬆️
database/gdb/gdb_core_underlying.go 73.48% <100.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hailaz hailaz requested a review from houseme August 2, 2023 02:14
@gqcn gqcn merged commit a4e7cc4 into master Aug 3, 2023
27 checks passed
@gqcn gqcn deleted the fix/2773 branch August 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants