Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve support for generic router registering #2877

Merged
merged 1 commit into from Aug 17, 2023
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 17, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3df5969) 79.16% compared to head (d5caacc) 79.16%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2877   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files         634      634           
  Lines       52432    52431    -1     
=======================================
  Hits        41508    41508           
  Misses       8861     8861           
+ Partials     2063     2062    -1     
Flag Coverage Δ
go-1.18-386 79.27% <100.00%> (+0.03%) ⬆️
go-1.18-amd64 79.21% <100.00%> (-0.01%) ⬇️
go-1.19-386 79.06% <100.00%> (+<0.01%) ⬆️
go-1.19-amd64 79.13% <100.00%> (+<0.01%) ⬆️
go-1.20-386 79.24% <100.00%> (+0.08%) ⬆️
go-1.20-amd64 79.25% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
net/ghttp/ghttp_server_service_handler.go 63.26% <100.00%> (-0.25%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 53323f3 into master Aug 17, 2023
17 of 18 checks passed
@gqcn gqcn deleted the enhance/generic-router branch August 17, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants