Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error stack configuration for package gerror, add framework error stack filter for package glog #2918

Merged
merged 2 commits into from Aug 31, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 31, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02% ⚠️

Comparison is base (7d4c59a) 79.16% compared to head (dadf231) 79.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2918      +/-   ##
==========================================
- Coverage   79.16%   79.15%   -0.02%     
==========================================
  Files         638      638              
  Lines       52557    52570      +13     
==========================================
+ Hits        41608    41611       +3     
- Misses       8884     8893       +9     
- Partials     2065     2066       +1     
Flag Coverage Δ
go-1.18-386 79.18% <66.66%> (-0.05%) ⬇️
go-1.18-amd64 79.24% <66.66%> (+0.01%) ⬆️
go-1.19-386 79.13% <66.66%> (+0.01%) ⬆️
go-1.19-amd64 79.12% <66.66%> (-0.03%) ⬇️
go-1.20-386 79.19% <66.66%> (-0.03%) ⬇️
go-1.20-amd64 79.22% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/errors/errors.go 42.85% <42.85%> (ø)
errors/gerror/gerror_error_stack.go 87.15% <100.00%> (-1.74%) ⬇️
os/glog/glog_logger.go 73.62% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 3f69e0d into master Aug 31, 2023
18 checks passed
@gqcn gqcn deleted the enhance/gerror-brief branch August 31, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants