Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue reading resource from manage in function New of package gres #2961

Merged
merged 19 commits into from Oct 10, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Sep 14, 2023

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d10d968) 77.71% compared to head (947583e) 77.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
- Coverage   77.71%   77.67%   -0.04%     
==========================================
  Files         647      647              
  Lines       54587    54666      +79     
==========================================
+ Hits        42424    42464      +40     
- Misses      10018    10046      +28     
- Partials     2145     2156      +11     
Flag Coverage Δ
go-1.18-386 77.64% <86.44%> (-0.02%) ⬇️
go-1.18-amd64 77.66% <86.44%> (-0.06%) ⬇️
go-1.19-386 77.58% <86.44%> (-0.04%) ⬇️
go-1.19-amd64 77.62% <86.44%> (?)
go-1.20-386 77.63% <86.44%> (?)
go-1.20-amd64 77.59% <86.44%> (?)
go-1.21-386 77.64% <86.44%> (+<0.01%) ⬆️
go-1.21-amd64 77.65% <86.44%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
i18n/gi18n/gi18n_ctx.go 54.54% <0.00%> (-45.46%) ⬇️
i18n/gi18n/gi18n_manager.go 77.55% <87.93%> (-4.06%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
i18n/gi18n/gi18n_z_unit_test.go Show resolved Hide resolved
@gqcn gqcn changed the title fix: gi18n default manager无法读取gres资源问题 fix issue reading resource from manage in function New of package gres Sep 14, 2023
i18n/gi18n/gi18n_ctx.go Outdated Show resolved Hide resolved
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
@hailaz hailaz requested a review from gqcn September 19, 2023 08:33
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
@hailaz hailaz requested a review from gqcn September 21, 2023 05:11
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
@hailaz hailaz requested a review from gqcn September 27, 2023 03:42
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
i18n/gi18n/gi18n_manager.go Outdated Show resolved Hide resolved
@hailaz hailaz requested a review from gqcn October 9, 2023 15:17
@hailaz hailaz added the done This issue is done, which may be release in next version. label Oct 10, 2023
@gqcn gqcn merged commit 3cd0059 into master Oct 10, 2023
24 checks passed
@gqcn gqcn deleted the fix/2874 branch October 10, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This issue is done, which may be release in next version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants