Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2890 #3002

Merged
merged 1 commit into from Oct 9, 2023
Merged

fix issue #2890 #3002

merged 1 commit into from Oct 9, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Oct 8, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (00e83fe) 77.31% compared to head (e982920) 77.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage   77.31%   77.25%   -0.06%     
==========================================
  Files         645      645              
  Lines       54347    54456     +109     
==========================================
+ Hits        42019    42071      +52     
- Misses      10217    10264      +47     
- Partials     2111     2121      +10     
Flag Coverage Δ
go-1.18-386 77.27% <69.84%> (-0.12%) ⬇️
go-1.18-amd64 77.31% <69.84%> (-0.06%) ⬇️
go-1.19-386 77.22% <69.84%> (?)
go-1.19-amd64 77.19% <69.84%> (-0.05%) ⬇️
go-1.20-386 77.30% <69.84%> (+0.02%) ⬆️
go-1.20-amd64 77.25% <69.84%> (-0.12%) ⬇️
go-1.21-386 77.31% <69.84%> (-0.07%) ⬇️
go-1.21-amd64 77.32% <69.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
util/gvalid/gvalid.go 81.25% <ø> (+2.67%) ⬆️
util/gvalid/gvalid_register.go 23.68% <ø> (-10.94%) ⬇️
util/gvalid/gvalid_validator.go 78.83% <100.00%> (-5.60%) ⬇️
util/gvalid/gvalid_validator_check_map.go 86.71% <100.00%> (-2.00%) ⬇️
util/gvalid/gvalid_validator_check_struct.go 81.31% <100.00%> (-4.24%) ⬇️
util/gvalid/gvalid_validator_check_value.go 93.02% <100.00%> (-5.64%) ⬇️
util/gvalid/internal/builtin/builtin.go 100.00% <ø> (ø)
util/gvalid/internal/builtin/builtin_enums.go 50.98% <42.42%> (-10.56%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit 8d925d4 into master Oct 9, 2023
23 of 24 checks passed
@gqcn gqcn deleted the fix/2890 branch October 9, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants