Fix submodule info loading #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes regression introduced in ebd9fb2, that GetSubModules was always returning empty submodule info because c.submoduleCache != nil check was always true since parseCommitData was setting commit.submoduleCache = newObjectCache() so it was always not-nil. Now we initialize submoduleCache in first GetSubModules call, next call will return cached entries.
This fixes GetCommitsInfo returning GetSubModule (/somemodule): object does not exist [id: , rel_path: .gitmodules] when /somemodule is a ref entry but no .gitmodules file is present. Instead failing we just check for IsErrNotExist and return empty submodule url. This also fixes HTTP 500 internal error in Gogs for case described above.
nanoant
added a commit
to nanoant/gogs
that referenced
this pull request
Jan 13, 2016
This is fixup for ea375c0. The bug was not visible because commit.RefUrl was always returning empty url due regression described in gogs/git-module#4
|
Thank you! |
strk
pushed a commit
to strk/git-module
that referenced
this pull request
Nov 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for more details.