Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mailer Reply-To override per project #3322

Open
gradha opened this issue Jul 25, 2016 · 7 comments
Open

Allow mailer Reply-To override per project #3322

gradha opened this issue Jul 25, 2016 · 7 comments
Labels
⛔ do not send pull request Don't ever think about it! 🎯 feature Categorizes as related to a new feature

Comments

@gradha
Copy link

gradha commented Jul 25, 2016

The mailer FROM configuration option I found in the cheat sheet is very useful. Would be really good if this FROM field could be customized per project to have different return addresses matching the appropriate mailing lists.

@unknwon
Copy link
Member

unknwon commented Jul 25, 2016

Thanks your feedback!

Why do you need this per project? Because issue-related email's From will eventually be the person who triggers the email notification. Seems nothing much useful places left.

@unknwon unknwon added the status: needs feedback Tell me more about it label Jul 25, 2016
@strk
Copy link
Contributor

strk commented Jul 25, 2016

I think in the long run the "From" should point to a temporary ad-hoc address setup to handle commenting by mail (see also #2602)

@unknwon
Copy link
Member

unknwon commented Jul 25, 2016

@strk I'm not pro on emailing, but I think reply-to-comment is the email header reply-to not from?

@strk
Copy link
Contributor

strk commented Jul 25, 2016

On Mon, Jul 25, 2016 at 09:26:26AM -0700, 无闻 wrote:

@strk I'm not pro on emailing, but I think reply-to-comment is the email header reply-to not from?

In presence of a Reply-To, yes, it takes precedence.
Github does use Reply-To for handling the by-mail replies.

@gradha
Copy link
Author

gradha commented Jul 25, 2016

As admin of a gogs instance I did set the FROM field to a separate personal email I didn't use. When users started replying to notifications those were lost until I checked that account. This meant that development conversation stalled for no apparent reason.

Not being related to those projects, setting repos for separate organizations would place an extra burden on me to deal with email forwarding in such situations, which then I'd have to look up these users in the database to send the email to the appropriate group.

Setting a From or Reply-To header for these groups would alleviate this administration burden.

@unknwon
Copy link
Member

unknwon commented Jul 26, 2016

@gradha I think what you need is Allow mailer Reply-To override per project instead of From?

@gradha
Copy link
Author

gradha commented Jul 26, 2016

If the effect is the same, yes.

@unknwon unknwon changed the title Allow mailer FROM override per project Allow mailer Reply-To override per project Jul 26, 2016
@unknwon unknwon added 🎯 feature Categorizes as related to a new feature ⛔ do not send pull request Don't ever think about it! and removed status: needs feedback Tell me more about it labels Jul 26, 2016
ethantkoenig pushed a commit to ethantkoenig/gogs that referenced this issue Feb 6, 2018
The makefile did not download the theme if the directory "themes/gitea"
is there, even if empty.
On a fresh Ubuntu install, curl is not included, so the theme rule fails
just after creating the empty directory. When you try again after
installing curl, the rule is not triggered.

This could also happen if the download fails for other reasons.

This change makes the theme rule depend on the file "theme.toml"
which will be there only after unpacking a successfully downloaded
theme archive.

Signed-off-by: Alberto González Palomo <bugs@sentido-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔ do not send pull request Don't ever think about it! 🎯 feature Categorizes as related to a new feature
Projects
None yet
Development

No branches or pull requests

3 participants