Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update profile for non-local users fails: Name cannot be empty #4313

Closed
dtrv opened this issue Mar 19, 2017 · 2 comments
Closed

Update profile for non-local users fails: Name cannot be empty #4313

dtrv opened this issue Mar 19, 2017 · 2 comments
Labels
💊 bug Something isn't working
Milestone
0.11

Comments

@dtrv
Copy link

dtrv commented Mar 19, 2017

Gogs version 0.10.18.0313
Debian GNU/Linux 8 (jessie)

Using LDAP (via BindDN) to authenticate user, the users can't change their profile settings.
Because for non-local user it's not allowed to change the user name, it seems that the user name is not sent to within the update request.

So "Name cannot be empty." pops up and updating the profile settings is not possible.
@unknwon unknwon added the 💊 bug Something isn't working label Mar 19, 2017
@unknwon unknwon added this to the 0.11 milestone Mar 19, 2017
@unknwon unknwon changed the title Update profile for non-local users fails: Name cannot be empty. Update profile for non-local users fails: Name cannot be empty Mar 19, 2017
@unknwon unknwon added the status: needs feedback Tell me more about it label Mar 20, 2017
unknwon added a commit that referenced this issue Mar 20, 2017
@unknwon
user/settings: fix cannot change profile for non-local users (#4313)
5f1bbbd
@unknwon
Copy link
Member

unknwon commented Mar 20, 2017

Patch has pushed to fix this issue, please test on develop branch.

@dtrv
Copy link
Author

dtrv commented Mar 21, 2017

dev branch, Gogs version 0.10.24.0320
Debian GNU/Linux 7 (wheezy)
Again Auth via LDAP (BindDN).

Update Profile settings for non-local users is possible. Thanks for patching!

@dtrv dtrv closed this as completed Mar 21, 2017
@unknwon unknwon removed the status: needs feedback Tell me more about it label Mar 21, 2017
@unknwon unknwon mentioned this issue Mar 25, 2017
Closed
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
2 participants
@unknwon @dtrv