Fix #807 parse the userinfo with the golang tools #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, this is now only fixed with Go version >= 1.4.2, see this bug in Go: golang/go@07d86b1
|
Thanks your PR!
I'm not sure what does this mean? Does this mean Gogs now requires Go 1.4.2? |
|
No, it does not mean Gogs requires Go 1.4, but the bug #807 is still present if Gogs is compiled with an older Go |
|
Anyway, I'm not sure why I wrote 1.4.2, I meant just Go 1.4 |
|
Thanks again! |
unknwon
added a commit
that referenced
this pull request
Jan 22, 2015
Fix #807 parse the userinfo with the golang tools
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is now only fixed with Go version >= 1.4.2, see this bug in Go: golang/go@07d86b1