Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for jsonpb support for Any and Struct #197

Open
awalterschulze opened this issue Sep 10, 2016 · 7 comments
Open

test for jsonpb support for Any and Struct #197

awalterschulze opened this issue Sep 10, 2016 · 7 comments
Assignees

Comments

@awalterschulze
Copy link
Member

This is blocked on
golang/protobuf#208
golang/protobuf#216

@awalterschulze awalterschulze self-assigned this Sep 11, 2016
@awalterschulze awalterschulze changed the title jsonpb support for Any and Struct jsonpb support for Any and Struct [blocked by golang/protobuf] Sep 11, 2016
@ZackButcher
Copy link

The blocking issues in golang/protobuf have been resolved as of golang/protobuf@18c9bb3.

@awalterschulze
Copy link
Member Author

awalterschulze commented Apr 28, 2017 via email

@ZackButcher
Copy link

Excellent, thank you!

@awalterschulze
Copy link
Member Author

Merged golang/protobuf@18c9bb3

@xor-gate
Copy link

Probably some tests should be reenable for gogo/protobuf: https://github.com/gogo/protobuf/blob/master/test/types/types.proto#L66-L68

@awalterschulze
Copy link
Member Author

Oooo good catch. How do you feel about making a pull request?

@awalterschulze awalterschulze changed the title jsonpb support for Any and Struct [blocked by golang/protobuf] test for jsonpb support for Any and Struct May 16, 2018
@xor-gate
Copy link

See PR #406, still it seems to fail on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants