Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users not allowed to write own Marshal and Unmarshal methods in new golang/protobuf API #388

Open
awalterschulze opened this issue Feb 25, 2018 · 1 comment
Open

Users not allowed to write own Marshal and Unmarshal methods in new golang/protobuf API #388

awalterschulze opened this issue Feb 25, 2018 · 1 comment
Labels
depends-on-golangprotobuf

Comments

@awalterschulze
Copy link
Member

I have made an issue with golang/protobuf
golang/protobuf#530
awalterschulze added a commit that referenced this issue Feb 25, 2018
@awalterschulze
disable asymetric-issue125 since #388 is broken
6407301
@awalterschulze
Copy link
Member Author

When golang/protobuf fixes this, we should also re-enable this test
6407301

awalterschulze added a commit that referenced this issue Apr 5, 2018
@awalterschulze
Upstream (#399): Merging upstream from golang/protobuf into dev branch …
44af720 
…golang/protobuf@8cc9e46

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345from golang/protobuf: add remap

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: moved testdata to test_proto, merged some tests and some prototext stuff

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: equal and equal_test

* update golden

* only golden test protoc 3 and up

* dont do golden test if file was not generated

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: clone and clone_test

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf size_test and size2_test

* merging 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: conformance.go

* merge extensions_test.go 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf

* merge 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: the biggest chunk

* upstream: more extensions test are passing

* marshal and unmarshal nullable=false messages and slices of messages

* merge 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf rest of all_test.go

* upstream: add NewRequiredNotSetError back

* upstream: simplify remove properties_gogo and fix NidRepNative size

* upstream: fix customtypes

* upstream: forgot customtype

* upstream: fix customtypes in maps

* upstream: add time.Time and time.Duration again

* merge 8cc9e46429bfb16289d40d30b2ee3f4923b47345 from golang/protobuf: generator.go

* merge 925541529c1fa6821df4e44ce2723319eb2be768 from golang/protobuf: add unrecognized for proto3, merge discard_test.go and finish merging all_test.go

* disable asymetric-issue125 since #388 is broken

* upstream: fix for embedded oneof

* upstream: vet fixes and stable marshaler

* merge: non nullable struct

* fix for extensions no map test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
depends-on-golangprotobuf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awalterschulze