Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: grpc code generation is not gated by a flag #60

Closed
tamird opened this issue Jun 8, 2015 · 2 comments
Closed

Bug: grpc code generation is not gated by a flag #60

tamird opened this issue Jun 8, 2015 · 2 comments

Comments

@tamird
Copy link
Contributor

tamird commented Jun 8, 2015

The default implementation requires a flag --go_out=plugins=grpc to generate services (see https://github.com/grpc/grpc-common/tree/master/go#optional---rebuilding-the-generated-code), but gogoproto always generates them, which is sometimes undesired (e.g. when a project is generating custom code for rpc that isn't grpc)

@awalterschulze
Copy link
Member

Ug :(
Good point.
I didn't think anyone would notice, I mean grpc is so awesome, why wouldn't you want it.
But I think this breaks my own rule.
This is definitely a bug.

@awalterschulze awalterschulze changed the title grpc code generation is not gated by a flag Bug: grpc code generation is not gated by a flag Jun 11, 2015
@awalterschulze
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants