Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: gofast does not support grpc and some doc for grpc would be nice #68

Closed
chakrit opened this issue Jun 12, 2015 · 10 comments
Closed

Comments

@chakrit
Copy link

chakrit commented Jun 12, 2015

Like the title says. I have the file in this gist: https://gist.github.com/chakrit/9708ad015e85cbf4e7bf which is just a hello world service.

The command invoked is:

$ protoc --gofast_out=plugins=grpc:./src/generated *.proto

But the resulting Go file contains no mention of Greeter at all.

@chakrit
Copy link
Author

chakrit commented Jun 12, 2015

Also can't find any mention about gRPC anywhere in the README or the doc pages.

@chakrit
Copy link
Author

chakrit commented Jun 12, 2015

It seems that all the various generator binaries do not make any use of the gRPC plugin flag and only the protoc-gen-gogo actually output a gRPC interface (regardless of the flag.)

Had to look in the letmegrpc project sources to discover that.

@awalterschulze
Copy link
Member

This is atleast tied to this issue
#60

@awalterschulze
Copy link
Member

I should add readme instructions as well.

@awalterschulze
Copy link
Member

Yes it seems gofast does not support grpc. This is a bug.

@awalterschulze awalterschulze changed the title Question: How to use with gRPC? Bug: gofast does not support grpc and some doc for grpc would be nice Jun 12, 2015
@awalterschulze
Copy link
Member

bug fixed.
Now just some docs.

@awalterschulze
Copy link
Member

Added a one line doc to the Readme.md

@awalterschulze
Copy link
Member

Thanks again for reporting.
I have made some major oversights.
Sorry for the inconvenience.

@chakrit
Copy link
Author

chakrit commented Jun 15, 2015

@awalterschulze thanks for fixing it so quickly :)

@awalterschulze
Copy link
Member

My pleasure. Thanks for reporting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants