plugin/populate: avoid loops on non top-level packages #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💛 |
|
Beautiful :) Could you just regenerate the code, because the diff check is failing. |
|
Heh, turns out that one-line diff was actually pointing out that my new approach was (still) wrong. Type names can include the names of other types, so simply stripping off the last component isn't sufficient to determine the package either. Updated with a new approach which plumbs the package name from the file descriptor. I'm hopeful that's bulletproof. |
|
Is it possible to also include your example as a test?
…On Thu, 30 Nov 2017, 21:07 Nikhil Benesch, ***@***.***> wrote:
Heh, turns out that one-line diff was actually pointing out that my new
approach was (still) wrong. Type names can include the names of other
types, so simply stripping off the last component isn't sufficient to
determine the package either.
Updated with a new approach which plumbs the package name from the file
descriptor. I'm hopeful that's bulletproof.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#357 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLWdfljzKNyOmOpMtqnvG6G3snQeoks5s7wrugaJpZM4QxBYH>
.
|
The previous scheme for detecting when a type belonged to a different package only considered the topmost component of the type name, but this is not a sufficiently general means of determining a type's package, as package names can themselves contain dots. Get the package name from the file descriptor instead, which is guaranteed to be correct. Also add a test to ensure this doesn't break in the future. Fix #207 (again).
|
Indeed, the ref I just pushed does exactly that :) |
|
Awesome I'll be at a computer soon.
…On Thu, 30 Nov 2017, 21:10 Nikhil Benesch, ***@***.***> wrote:
Indeed, the ref I just pushed does exactly that :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#357 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLY1d3VaaLz-cNQe6RLDiUcgjZw7vks5s7wvOgaJpZM4QxBYH>
.
|
|
Whew, it's green! Thanks for the crazy fast response time, @awalterschulze. |
|
Perfect :) |
|
Any time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous scheme for detecting when a type belonged to a different
package only considered the topmost component of the type name, when it
in fact needs to consider all but the last component of the type name.
Fix #207 (again).