Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[merge] Fix merge of non-nullable slices #569

Merged
merged 1 commit into from
Jul 30, 2019
Merged

[merge] Fix merge of non-nullable slices #569

merged 1 commit into from
Jul 30, 2019

Conversation

euroelessar
Copy link
Contributor

Fixes #568

@euroelessar
Copy link
Contributor Author

@jmarais Hi, can you check the change, please?

@euroelessar euroelessar mentioned this pull request May 14, 2019
Closed
@jmarais
Copy link
Contributor

jmarais commented May 15, 2019 •
edited
Loading

Thanks. This looks good.
I see a fmt check fail.
Could you reformat your test file please?

@kyessenov kyessenov mentioned this pull request Jul 21, 2019
Merged
@euroelessar euroelessar force-pushed the fix-memory-corruption-on-clone branch from b5e14d8 to 9bb2472 Compare July 21, 2019 05:23
@rshriram
Copy link

Thanks for the fix @euroelessar . We have stumbled upon this bug as well in Istio project.

@rshriram
Copy link

@jmarais if this PR is okay, could you merge this?

@rshriram
Copy link

Ping

@rshriram
Copy link

gentle ping again. We are blocked on this for a major feature [getting seg faults in proto.Merge)

@geeknoid geeknoid mentioned this pull request Jul 30, 2019
Merged
@jmarais
Copy link
Contributor

jmarais commented Jul 30, 2019

Sorry for the delay. Thanks for the update.

@jmarais jmarais merged commit 28a6bbf into gogo:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrdada mehrdada mehrdada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory corruption/panic on Clone/Merge of nonnullable repeated field
4 participants
@euroelessar @jmarais @rshriram @mehrdada