Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoString plugin: generate values instead of pointers when a field is repeated and non-nullable. #631

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

godfried
Copy link
Contributor

@godfried godfried commented Oct 1, 2019

See #630

@godfried
Copy link
Contributor Author

godfried commented Oct 1, 2019

I haven't regenerated any of the other protos yet.

@jmarais
Copy link
Contributor

jmarais commented Oct 6, 2019

Thanks for the pull request.

Currently there is only one test case for a repeated non-nullable message, can you please add another test for the repeated nullable case?

The travis check is currently failing because of the changes in the generated pb.go files. You will need to regenerate all the pb.go files.

@jmarais jmarais merged commit 8142193 into gogo:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants