Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and updates #36

Merged
merged 5 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@Puritanic
Copy link
Member

commented Jul 6, 2018

Updated README, and fixed two issues; In one case we've unintentionally directly mutated ComboSelect state, which caused a nasty bug where the value in ComboSelect wasn't updating correctly. Another one was related to groups, issues with selecting value too, because I was checking array of values with contains() to find selected one, but when we had just a single string value that was causing an issue where values with similar names (GI and GIT, for example) were both selected, instead of just picking one.

@@ -1,3 +1,4 @@
/* eslint-disable */

This comment has been minimized.

Copy link
@NikolaRavic

NikolaRavic Jul 6, 2018

Contributor

You forgot this? @Puritanic

This comment has been minimized.

Copy link
@Puritanic

Puritanic Jul 9, 2018

Author Member

Yeah :D Removed now.

@NikolaRavic NikolaRavic merged commit fc34f1d into gogoair:master Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.