Support for Sidekiq 2.3 or higher. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was throwing "FloatDomainError: NaN"
Previous commit coerced the nil/empty value to zero. This commit actually traps the division by zero.
|
This pull request also adds error handling to paging. |
|
@scarver2 It doesn't work for Sidekiq 3.2.1 (the version I'm using). It only seems to work for versions higher than 2.3 but less than 2.4. Could you get it working for 3.2? That would be awesome! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes all specs and has been tested in production. I recommend not capping the maximum version of Sidekiq until an incompatibility is identified.