Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't tab into "close and comment" button #1917

Closed
ChangePlaces opened this issue Nov 10, 2015 · 15 comments
Closed

Can't tab into "close and comment" button #1917

ChangePlaces opened this issue Nov 10, 2015 · 15 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Milestone

Comments

@ChangePlaces
Copy link

I think related to #1824 it seems impossible to tab into the close and comment button after typing the message.

@unknwon unknwon added 💊 bug Something isn't working 💻 ui You ruined my eyes! labels Nov 10, 2015
@unknwon unknwon added this to the 0.8.0 milestone Nov 10, 2015
makhov pushed a commit to makhov/gogs that referenced this issue Nov 11, 2015
@unknwon unknwon modified the milestones: 0.7.x, 0.8.0 Nov 11, 2015
@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

You should now be able to use tab switch to buttons and press enter key to trigger click event on develop and https://try.gogs.io .

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 11, 2015
@ChangePlaces
Copy link
Author

I've been trying to tab here https://try.gogs.io/asdf3/test2/issues/1#issuecomment-363

One tab hits the comment button, and two presses appears to not hit the close button

@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

@ChangePlaces make sure you did hard refresh, and the order is textarea - comment - comment and close, the highlight for comment and close is not visible.

@ChangePlaces
Copy link
Author

ohhh I use the spacebar key to simulate a button press which doesn't work (but works for the comment button). I see the enter key works though here

@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

Yes, I have explicitly said works with enter key.

@unknwon unknwon closed this as completed Nov 11, 2015
@unknwon unknwon reopened this Nov 11, 2015
@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

OK, I think I can make space bar work as well.

@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

Please do a hard refresh and test with space bar.

@ChangePlaces
Copy link
Author

just tested, and space bar doesn't have any effect other than scrolling the page down!

@unknwon
Copy link
Member

unknwon commented Nov 12, 2015

I'm very sure space bar works.

@ChangePlaces
Copy link
Author

I type something in the comment box, then press tab and I'm on the comment button, I press tab again, and then press space and nothing happens other than the page scrolling down!

@unknwon
Copy link
Member

unknwon commented Nov 12, 2015

I just follow the steps you provided and made the comment: https://try.gogs.io/gogs/gogs/issues/26#issuecomment-373

@ChangePlaces
Copy link
Author

interesting - i'm using firefox 42 - you?

@unknwon
Copy link
Member

unknwon commented Nov 12, 2015

Chrome 46... I think it's better to use enter key.

@ChangePlaces
Copy link
Author

the tab key is on the left side of the keyboard, the enter key is on the far right side. so it becomes difficult to comment / close and comment with one hand negating the use of a keybaord shortcut!

@unknwon
Copy link
Member

unknwon commented Nov 12, 2015

the tab key is on the left side of the keyboard, the enter key is on the far right side. so it becomes difficult to comment / close and comment with one hand negating the use of a keybaord shortcut!

I do not get the point at all. If just one side, why use keyboard at all?

makhov pushed a commit to makhov/gogs that referenced this issue Nov 12, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Projects
None yet
Development

No branches or pull requests

2 participants