-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows service could not be started using nssm with 0.8.0, but 0.7.33 is ok. #2189
Comments
Hi, the way Gogs supports Windows service in since 0.8 has been changed: https://gogs.io/docs/installation/install_gogs_on_windows#run-gogs-as-a-service |
Same here. v0.8.0 simply doesn't work anymore. v0.7.33 is OK.
Does this mean using Gogs with NSSM was discontinued? |
Actually I don't know how and why NSSM was working... but recommend way right is using the builtin ability. |
1.Useing nssm to building as service run at Local Area Network not just local machine, the configuration file is the same for 0.7.33 and 0.8.0, the first is running correctly, but the second failed. 2.Try the link https://gogs.io/docs/installation/install_gogs_on_windows#run-gogs-as-a-service, but it is not worked at local machine also. |
@bygreencn please read my comments. |
@unknwon Yes, but i really think something was wrong at version 0.8.0. |
This is the only change relates to Windows: https://github.com/gogits/gogs/pull/2133/files |
I really know nothing about Windows service, maybe you guys can help... |
@unknwon yeah, i think gogs and nssm also set and check the service status, which cause nssm decide the service failed, but the minwinsvc service stub run not correctly. Maybe it is not the best choice. |
Another person had the exactly same problem, he used to use NSSM, but he has successfully changed to minwinsvc now by following the docs. |
Also could you please give some manual to compile gogs at windows platform, i want to build it from myself and cancel this pull request. thanks a lot!!! |
I think is kind of potentially breaking change should be tested by more people. You can always have it in an separated branch first and tell people to test it. If we have sure it works, so it can be merged. |
@bygreencn the docs are pretty much same for Windows, just replace some commands that are not available for Windows: https://gogs.io/docs/installation/install_from_source @andreynering not many people will test until things break... |
OK... the ultimate solution again, maybe we should add a build tag? |
The question is ... if miniwinsvc does do the work, change from NSSM to this is just once forever change. |
I never used miniwinsvc before. I don't even know how it work. |
The link I gave described how it works: https://gogs.io/docs/installation/install_gogs_on_windows#run-gogs-as-a-service |
I tried commenting the import line and NSSM worked again. It seems that we can't use both at the same time. |
So...... do we need a tag to disable this line? |
Is it possible to make this import optional while compiling? If yes, I think it would be good, at least for some more releases, so people have more time to migrate to the new service mode. |
Yes, but it does not solve the problem actually... as every binary release will include all tags possible. |
What is the status of this issue now? |
I think if you want to support both NSSM and native service you will need to make two separated binaries. |
Looks like so... 😭 |
OK, now in |
No description provided.
The text was updated successfully, but these errors were encountered: