Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package don't play well with NSSM #1

Closed
andreynering opened this issue Dec 18, 2015 · 2 comments
Closed

This package don't play well with NSSM #1

andreynering opened this issue Dec 18, 2015 · 2 comments

Comments

@andreynering
Copy link

See gogs/gogs#2189

When this package is included, NSSM stops working. It would be good if we could prevent minwinsvc from being executed.

@kardianos
Copy link
Owner

@andreynering The fix would be to alter https://godoc.org/golang.org/x/sys/windows/svc#IsAnInteractiveSession
to detect if there is a parent process being run as a service. Not entirely sure if that will work though. Feel free to try though.

The problem you describe is minwinsvc detects it is being run under a windows service and tries to register the needed callbacks, but NSSM already has. Chaos ensues.

Otherwise because minwinsvc manages the windows service natively, you don't need to use nssm anymore.

@andreynering
Copy link
Author

Thank you for the information. I may take a look.

Otherwise because minwinsvc manages the windows service natively, you don't need to use nssm anymore.

I agree. I don't know how many people uses NSSM vs. Native with Gogs, but everybody that uses NSSM would have to migrate to be able to upgrade. By now, there are duplicated builds: https://github.com/gogits/gogs/releases/tag/v0.8.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants