Markdown code blocks not rendered correctly

[stonewareslord]

We DO NOT take questions or config/deploy problems on GitHub, please use our forum: https://discuss.gogs.io

Please take a moment to search that an issue doesn't already exist.

For bug reports, please give the relevant info:

• Gogs version (or commit ref): 0.9.30.0601
• Git version: Unknown
• Operating system: Unknown
• Database:
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at http://try.gogs.io:
  • Yes: https://try.gogs.io/stonewareslord/test/src/master/test.md, source: https://try.gogs.io/stonewareslord/test/raw/master/test.md
  • No
  • Not relevant
• Log gist:

Description

Using the characters []: breaks a code block and renders the entire line and sometimes the next line blank.

[bkcsoft]

I'll have a look at this tomorrow, but it's most likely a bug in blackfriday (the markdown-parser/renderer) and not Gogs itself.

[bkcsoft]

Yes it's an issue with https://github.com/russross/blackfriday https://gist.github.com/bkcsoft/dce1a2e16db28b46e1ce4c8df18caaba

[xor-gate]

@bkcsoft is this reported upstream to russross/blackfriday ?, this would be a good idea and cross-reference to this issue also.

[bkcsoft]

Not yet, I'll do that now :)

[xor-gate]

Define now @bkcsoft :+), i looked at the issue tracker of russross/blackfriday and have not yet seen the issue.

[bkcsoft]

@xor-gate "now" as in now russross/blackfriday#279

Sorry, other issues have had priority :)

[xor-gate]

👍 first things first, good for having this also active upstream.

[dmitshur]

Thanks for reporting the bug in blackfriday. I've fixed it in russross/blackfriday#280, so this should no longer be an issue.

You'll need to update to latest version if you're vendoring blackfriday.

[xor-gate]

Nice work @shurcooL !!!

[unknwon]

Looks like fixed: https://try.gogs.io/stonewareslord/test/src/master/test.md

[gsantner]

Happens still on my gogs. version 0.9.83.0816.

[dmitshur]

@gsantner, can you please check if that problem occurs in the latest master version of blackfriday?

If so, please report it in that repo. Otherwise, gogs just needs to update the outdated vendored version it's using.

Also, are you using latest version of gogs? If not, try latest.