Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request webhook should provide information when milestone is set/cleared #3485

Closed
2 of 6 tasks
hhenkel opened this issue Aug 19, 2016 · 3 comments
Closed
2 of 6 tasks
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Milestone

Comments

@hhenkel
Copy link

hhenkel commented Aug 19, 2016

  • Gogs version (or commit ref): 0.9.83.0816
  • Git version: 1.8.3.1
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at https://try.gogs.io:
    • Yes (provide example URL)
    • No
    • Not relevant

The current implementation of the pull request webhook generates events for the assignee and the label changes but nothing seems to be triggered for milestones.

@unknwon
Copy link
Member

unknwon commented Aug 19, 2016

I don't understand the title.

@unknwon unknwon added the status: needs feedback Tell me more about it label Aug 19, 2016
@hhenkel
Copy link
Author

hhenkel commented Aug 19, 2016

Sorry - typing and talking at the sametime sometimes gives strange results....trying to clearify.

@hhenkel hhenkel changed the title Pull request webhook should provides no information when milestone is set/cleared Pull request webhook should provide information when milestone is set/cleared Aug 19, 2016
@unknwon unknwon added 🔨 enhancement Make it better, faster and removed status: needs feedback Tell me more about it labels Aug 19, 2016
@unknwon unknwon modified the milestone: 0.11.0 Feb 18, 2017
unknwon added a commit that referenced this issue Mar 9, 2017
@unknwon unknwon added the status: needs feedback Tell me more about it label Mar 9, 2017
@unknwon
Copy link
Member

unknwon commented Mar 9, 2017

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io.

@unknwon unknwon closed this as completed Mar 10, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Development

No branches or pull requests

2 participants