Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still trouble with local webhooks #7074

Closed
1 task done
grasshide opened this issue Jun 25, 2022 · 3 comments · Fixed by #7075
Closed
1 task done

Still trouble with local webhooks #7074

grasshide opened this issue Jun 25, 2022 · 3 comments · Fixed by #7075
Assignees
Labels
💊 bug Something isn't working
Milestone

Comments

@grasshide
Copy link

Gogs version

0.13.0+dev

Git version

  • Server: 2.32.2
  • Client: intellij

Operating system

debian

Database

postgres:9.5

Describe the bug

Since some change, gogs would not let me put any local URL in the webhook URL field. That was fixed with this Issue: #7051 when I added:
LOCAL_NETWORK_ALLOWLIST = 192.168.1.200

I thought that would be it, but non of my webhooks are actually firing.
So I set the log to trace instead of info and I'm getting this:
[ERROR] [...s.io/gogs/internal/db/webhook.go:490 AfterSet()] Unmarshal [452]: readObjectStart: expect { or n, but found P, error found in #1 byte of ...|Payload URL|..., bigger context ...|Payload URL resolved to a local network address tha|...

Not sure what this means, but I think there is still some local restriction in place.

To reproduce

My settings are the very basic for the webhook:
URL: http://192.168.1.200:8555/some-token
Content Type: application/json
Just push the event
active

Expected behavior

I expect the webhook to be triggered. But noting ever arrives on the target side.

Additional context

gogs: image: gogs/gogs:latest container_name: gogs

Code of Conduct

  • I agree to follow this project's Code of Conduct
@grasshide grasshide added the 💊 bug Something isn't working label Jun 25, 2022
@unknwon unknwon mentioned this issue Jun 25, 2022
1 task
@unknwon unknwon self-assigned this Jun 25, 2022
@unknwon unknwon added this to the 0.12.10 milestone Jun 25, 2022
@unknwon
Copy link
Member

unknwon commented Jun 25, 2022

Thanks for the feedback! PR is coming in #7075

@grasshide
Copy link
Author

Thanks!

@unknwon
Copy link
Member

unknwon commented Aug 2, 2022

The 0.12.10 has been released that includes the patch of the reported issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💊 bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants