Fix #3743: Fix SHA and compare regex on route file [Critical] #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
reviewed
Nov 4, 2016
|
|
||
| m.Get("/compare/:before([a-z0-9]{7,40})\\.\\.\\.:after([a-z0-9]{7,40})", repo.CompareDiff) | ||
| m.Get("/compare/:before([a-z0-9]{40})\\.\\.\\.:after([a-z0-9]{40})", repo.CompareDiff) |
There was a problem hiding this comment.
And now I can't compare master...develop anymore 😒
There was a problem hiding this comment.
are you sure ?
EDIT: just tested, it working!
http://127.0.0.1:3000/test/core/compare/master...develop
There was a problem hiding this comment.
oh [a-z], I read it as [a-f] 😄
|
+1 |
|
is this also already fixed in gitea ? |
|
looks like it is: https://github.com/go-gitea/gitea/blob/master/cmd/web.go#L590 |
|
Thanks! |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue #3743, this pull request fix the regex used on the route file for SHA and branches comparisons.
a b c d e f 0 1 2 3 4 5 6 7 8 9