Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_editor: prohibits uploading files to .git. directory #6970

Merged
merged 4 commits into from May 30, 2022
Merged

Conversation

1135
Copy link

@1135 1135 commented May 26, 2022

Describe the pull request

I try to fix it, but it's not necessarily the best solution.
This commit is for informational purposes only. No test cases have been added yet.

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

internal/db/repo_editor.go Outdated Show resolved Hide resolved
@unknwon unknwon added the status: needs followup Need some extra work label May 26, 2022
@unknwon unknwon linked an issue May 26, 2022 that may be closed by this pull request
1 task
@unknwon unknwon changed the title path check repo_editor: prohibits uploading files to .git. directory May 30, 2022
@unknwon unknwon removed the status: needs followup Need some extra work label May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #6970 (249c4e0) into main (e65071d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##            main   #6970      +/-   ##
========================================
+ Coverage   8.89%   8.91%   +0.02%     
========================================
  Files         99      99              
  Lines      13262   13265       +3     
========================================
+ Hits        1179    1182       +3     
  Misses     11917   11917              
  Partials     166     166              

@unknwon unknwon merged commit 519aeef into gogs:main May 30, 2022
unknwon added a commit that referenced this pull request May 31, 2022
Co-authored-by: Joe Chen <jc@unknwon.io>
dna2github pushed a commit to dna2fork/gogs that referenced this pull request May 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS Command Injection in file uploading
2 participants