Make Signup button display configurable - #884 #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolai86
changed the title
nicolai86
changed the title
|
I left out all the locales because I have to look them up yet. Will add those soon… |
|
We now have the translations as well, except for lv and zh-HK |
|
Thanks your PR! But we don't do translation in here: see readme, except for English. |
|
@unknwon should I leave the new key for every language, or just revert the last commit except for the english translation? |
|
Actually it doesn't mattar, non-English files will be eventually overwritten. Your PR looks good otherwise, will merge soon. :) |
|
Cool. I'll leave the PR as is then :) |
unknwon
added a commit
that referenced
this pull request
Feb 7, 2015
Make Signup button display configurable - #884
|
Merged, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #884 for the original request. I'd love some feedback for the tiny CR since it's my first.