Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added test for utils and login #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions cmd/harbor/root/login_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package root

import (
"net/http"
"net/http/httptest"
"testing"

"github.com/goharbor/harbor-cli/pkg/views/login"
"github.com/stretchr/testify/assert"
)

func TestRunLogin_Successful(t *testing.T) {
// Mock Harbor server
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/api/v2.0/users/current", r.URL.Path)
w.WriteHeader(http.StatusOK)
}))
defer mockServer.Close()
opts := login.LoginView{
Server: mockServer.URL,
Username: "testuser",
Password: "testpassword",
}
err := runLogin(opts)
assert.NoError(t, err)
}

func TestRunLogin_Failed(t *testing.T) {
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/api/v2.0/users/current", r.URL.Path)
w.WriteHeader(http.StatusUnauthorized)
}))
defer mockServer.Close()
opts := login.LoginView{
Server: mockServer.URL,
Username: "testuser",
Password: "testpassword",
}
err := runLogin(opts)
assert.Error(t, err)
assert.Contains(t, err.Error(), "login failed")
}

func TestLoginCommand(t *testing.T) {
cmd := LoginCommand()
flags := cmd.Flags()

// Test case 1: required flags value should be set
cmd.SetArgs([]string{"http://testgoharbor.io"})
flags.Set("username", "testuser")
flags.Set("password", "testpass")

assert.NotEmpty(t, cmd.Args, "serverAddress cmd argument has already set")
usernameFlag, err := flags.GetString("username")
assert.NoError(t, err, "Expected no error getting username flag")
assert.NotEmpty(t, usernameFlag, "Expected username flag has already set")
passwordFlag, err := flags.GetString("password")
assert.NoError(t, err, "Expected no error getting password flag")
assert.NotEmpty(t, passwordFlag, "Expected password flag has already set")

// Test case 2: required flags value should not be set
flags.Set("username", "")
flags.Set("password", "")
usernameFlag, _ = flags.GetString("username")
if usernameFlag == "" {
assert.Empty(t, usernameFlag, "Expected username flag has to be set")
}
passwordFlag, _ = flags.GetString("password")
if passwordFlag == "" {
assert.Empty(t, passwordFlag, "Expected password flag has to be set")
}
}
35 changes: 35 additions & 0 deletions pkg/utils/utils_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package utils

import (
"testing"

"github.com/goharbor/go-client/pkg/harbor"
)

func TestGetClientByConfig(t *testing.T) {
clientConfig := &harbor.ClientSetConfig{
URL: "testURL",
Username: "testUsername",
Password: "testPassword",
}
client := GetClientByConfig(clientConfig)
if client == nil {
t.Errorf("Expected client not to be nil")
}
}

func TestGetClientByCredentialName(t *testing.T) {
client := GetClientByCredentialName("127.0.0.1-testuser")
if client == nil {
t.Errorf("Expected client not to be nil")
}
}

func TestPrintPayloadInJSONFormat(t *testing.T) {
PrintPayloadInJSONFormat(nil)

payload := map[string]interface{}{
"testkey": "test-value",
}
PrintPayloadInJSONFormat(payload)
}