Skip to content

Commit

Permalink
Fix the nginx's containerPort (#1497)
Browse files Browse the repository at this point in the history
It is better to limit the nginx's containerPort and port to only those that are enabled.

8443 is valid only if .Values.expose.tls.enabled is true.
4443 is no longer used since notary was removed.

Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
  • Loading branch information
kariya-mitsuru committed Feb 14, 2024
1 parent 863d4d0 commit 53ce4a2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion templates/nginx/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ spec:
{{- end }}
ports:
- containerPort: 8080
{{- if .Values.expose.tls.enabled }}
- containerPort: 8443
- containerPort: 4443
{{- end }}
volumeMounts:
- name: config
mountPath: /etc/nginx/nginx.conf
Expand Down

0 comments on commit 53ce4a2

Please sign in to comment.